From 793c2441117a7ef24159682479d6c21e8aece327 Mon Sep 17 00:00:00 2001
From: Alexander Medvednikov <alexander@medvednikov.com>
Date: Tue, 14 Apr 2026 12:45:28 +0300
Subject: [PATCH] crypto: Tests fail for vlib/x/crypto/mldsa/usage_test.v
 (fixes #26827)

---
 vlib/x/crypto/mldsa/usage_test.v | 45 +++++++++++---------------------
 1 file changed, 15 insertions(+), 30 deletions(-)

diff --git a/vlib/x/crypto/mldsa/usage_test.v b/vlib/x/crypto/mldsa/usage_test.v
index bb7c44f38..31fb0f73b 100644
--- a/vlib/x/crypto/mldsa/usage_test.v
+++ b/vlib/x/crypto/mldsa/usage_test.v
@@ -4,46 +4,31 @@ module mldsa_test
 import x.crypto.mldsa
 
 fn test_mldsa_basic_sign_and_verify() ! {
-	mut pv := mldsa.PrivateKey.new()!
-	defer {
-		pv.free()
-	}
-	mut pb := pv.public_key()!
-	defer {
-		pb.free()
-	}
+	pv := mldsa.PrivateKey.generate(.ml_dsa_44)!
+	pb := pv.public_key()
 	msg := 'ml-dsa basic roundtrip'.bytes()
-	sig := pv.sign(msg)!
+	sig := pv.sign(msg, deterministic: true)!
 	assert sig.len > 0
-	assert pv.verify(sig, msg)!
-	assert pb.verify(sig, msg)!
-	assert !pb.verify(sig, 'ml-dsa mismatch'.bytes())!
+	assert pb.verify(msg, sig)!
+	mismatch := pb.verify('ml-dsa mismatch'.bytes(), sig)!
+	assert !mismatch
 }
 
 fn test_mldsa_seed_and_raw_key_roundtrip() ! {
 	kind := mldsa.Kind.ml_dsa_65
-	mut pv := mldsa.PrivateKey.new(kind: kind)!
-	defer {
-		pv.free()
-	}
-	seed := pv.seed()!
-	priv := pv.bytes()!
-	pub_bytes := pv.public_bytes()!
+	pv := mldsa.PrivateKey.generate(kind)!
+	seed := pv.seed()
+	priv := pv.bytes()
+	pub_bytes := pv.public_key().bytes()
 	assert seed.len == 32
 	assert priv.len == kind.private_key_size()
 	assert pub_bytes.len == kind.public_key_size()
 
-	mut pv_from_seed := mldsa.PrivateKey.from_seed(seed, kind)!
-	defer {
-		pv_from_seed.free()
-	}
-	assert pv_from_seed.bytes()! == priv
+	pv_from_seed := mldsa.PrivateKey.from_seed(seed, kind)!
+	assert pv_from_seed.bytes() == priv
 
-	mut pb := mldsa.PublicKey.from_bytes(pub_bytes, kind)!
-	defer {
-		pb.free()
-	}
+	pb := mldsa.PublicKey.from_bytes(pub_bytes, kind)!
 	msg := 'ml-dsa imported public key'.bytes()
-	sig := pv.sign(msg, deterministic: 1)!
-	assert pb.verify(sig, msg)!
+	sig := pv.sign(msg, deterministic: true)!
+	assert pb.verify(msg, sig)!
 }
-- 
2.39.5