From 769699ede6edba13f86c59d7a0ba9ec848f5fd93 Mon Sep 17 00:00:00 2001 From: Felipe Pena Date: Sat, 2 Nov 2024 05:58:05 -0300 Subject: [PATCH] cgen: fix spawn with non-pointer receiver (fix #22718) (#22719) --- vlib/v/gen/c/spawn_and_go.v | 4 ++++ ...awn_with_different_method_receivers_test.v | 23 +++++++++++++++++++ 2 files changed, 27 insertions(+) create mode 100644 vlib/v/tests/concurrency/spawn_with_different_method_receivers_test.v diff --git a/vlib/v/gen/c/spawn_and_go.v b/vlib/v/gen/c/spawn_and_go.v index 1d93ecd13..833b7891b 100644 --- a/vlib/v/gen/c/spawn_and_go.v +++ b/vlib/v/gen/c/spawn_and_go.v @@ -101,6 +101,10 @@ fn (mut g Gen) spawn_and_go_expr(node ast.SpawnExpr, mode SpawnGoMode) { } if expr.is_method { g.write('${arg_tmp_var}${dot}arg0 = ') + if expr.left is ast.Ident && expr.left.obj.typ.is_ptr() + && !node.call_expr.receiver_type.is_ptr() { + g.write('*') + } g.expr(expr.left) g.writeln(';') } diff --git a/vlib/v/tests/concurrency/spawn_with_different_method_receivers_test.v b/vlib/v/tests/concurrency/spawn_with_different_method_receivers_test.v new file mode 100644 index 000000000..8c10b811e --- /dev/null +++ b/vlib/v/tests/concurrency/spawn_with_different_method_receivers_test.v @@ -0,0 +1,23 @@ +struct Server {} + +fn (server Server) non_mutable_receiver() { + println(@LOCATION) +} + +fn (mut s Server) mutable_receiver() { + println(@LOCATION) +} + +fn (s &Server) reference_receiver() { + println(@LOCATION) +} + +fn test_spawning_threads_with_methods_that_have_mutable_and_non_mutable_receivers() { + mut server := &Server{} + t1 := spawn server.non_mutable_receiver() + t2 := spawn server.mutable_receiver() + t3 := spawn server.reference_receiver() + t1.wait() + t2.wait() + t3.wait() +} -- 2.39.5