From 730b3f5e0f997f88d833d4ca1b557da87cb33f12 Mon Sep 17 00:00:00 2001
From: Felipe Pena <felipensp@gmail.com>
Date: Thu, 31 Oct 2024 01:46:08 -0300
Subject: [PATCH] checker: check for receiver name clashing with global var
 (fix #22698) (#22708)

---
 vlib/v/checker/fn.v                           |  4 ++++
 .../globals/global_receiver_var_name_err.out  |  7 +++++++
 .../globals/global_receiver_var_name_err.vv   | 21 +++++++++++++++++++
 3 files changed, 32 insertions(+)
 create mode 100644 vlib/v/checker/tests/globals/global_receiver_var_name_err.out
 create mode 100644 vlib/v/checker/tests/globals/global_receiver_var_name_err.vv

diff --git a/vlib/v/checker/fn.v b/vlib/v/checker/fn.v
index b5ca4cf5f..617d6b5a3 100644
--- a/vlib/v/checker/fn.v
+++ b/vlib/v/checker/fn.v
@@ -192,6 +192,10 @@ fn (mut c Checker) fn_decl(mut node ast.FnDecl) {
 		}
 	}
 	if node.is_method {
+		if node.receiver.name in c.global_names {
+			c.error('cannot use global variable name `${node.receiver.name}` as receiver',
+				node.receiver_pos)
+		}
 		if node.receiver.typ.has_flag(.option) {
 			c.error('option types cannot have methods', node.receiver_pos)
 		}
diff --git a/vlib/v/checker/tests/globals/global_receiver_var_name_err.out b/vlib/v/checker/tests/globals/global_receiver_var_name_err.out
new file mode 100644
index 000000000..376984d3a
--- /dev/null
+++ b/vlib/v/checker/tests/globals/global_receiver_var_name_err.out
@@ -0,0 +1,7 @@
+vlib/v/checker/tests/globals/global_receiver_var_name_err.vv:17:9: error: cannot use global variable name `game` as receiver
+   15 | }
+   16 | 
+   17 | fn (mut game Game) init() {
+      |         ~~~~~~~~~
+   18 |     game.world = GameObject{}
+   19 | }
diff --git a/vlib/v/checker/tests/globals/global_receiver_var_name_err.vv b/vlib/v/checker/tests/globals/global_receiver_var_name_err.vv
new file mode 100644
index 000000000..b6547e51d
--- /dev/null
+++ b/vlib/v/checker/tests/globals/global_receiver_var_name_err.vv
@@ -0,0 +1,21 @@
+module main
+
+struct Game {
+mut:
+	world     GameObject
+	object_id u32
+}
+
+__global (
+	game Game
+)
+
+struct GameObject {
+	id int = game.object_id++
+}
+
+fn (mut game Game) init() {
+	game.world = GameObject{}
+}
+
+fn main() {}
-- 
2.39.5