From 0ef25012162b5ff212ad5656da95463d947b6d1c Mon Sep 17 00:00:00 2001 From: Swastik Baranwal Date: Sat, 27 Jul 2024 13:37:25 +0530 Subject: [PATCH] parser: improve the error for keyword `lock`, used as a variable name (#21937) --- vlib/v/parser/lock.v | 2 +- vlib/v/parser/tests/lock_var_name_assign_err.out | 3 +++ vlib/v/parser/tests/lock_var_name_assign_err.vv | 1 + 3 files changed, 5 insertions(+), 1 deletion(-) create mode 100644 vlib/v/parser/tests/lock_var_name_assign_err.out create mode 100644 vlib/v/parser/tests/lock_var_name_assign_err.vv diff --git a/vlib/v/parser/lock.v b/vlib/v/parser/lock.v index 69ba31703..21668095e 100644 --- a/vlib/v/parser/lock.v +++ b/vlib/v/parser/lock.v @@ -72,7 +72,7 @@ fn (mut p Parser) lock_expr() ast.LockExpr { for { is_rlock := p.tok.kind == .key_rlock if !is_rlock && p.tok.kind != .key_lock { - p.unexpected(expecting: '`lock` or `rlock`') + p.unexpected(expecting: 'one or more shared variable names') } p.next() if p.tok.kind == .lcbr { diff --git a/vlib/v/parser/tests/lock_var_name_assign_err.out b/vlib/v/parser/tests/lock_var_name_assign_err.out new file mode 100644 index 000000000..b2dbfb75f --- /dev/null +++ b/vlib/v/parser/tests/lock_var_name_assign_err.out @@ -0,0 +1,3 @@ +vlib/v/parser/tests/lock_var_name_assign_err.vv:1:6: error: unexpected token `:=`, expecting one or more shared variable names + 1 | lock := 12 + | ~~ diff --git a/vlib/v/parser/tests/lock_var_name_assign_err.vv b/vlib/v/parser/tests/lock_var_name_assign_err.vv new file mode 100644 index 000000000..c79d16f58 --- /dev/null +++ b/vlib/v/parser/tests/lock_var_name_assign_err.vv @@ -0,0 +1 @@ +lock := 12 -- 2.39.5